Semi taut mooring update #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g too low of a cost for the hybrid mooring system compared to other projects
…ow) the same mooring system as the turbines
…tion. now just one mooring system per oss.
…RBIT into SemiTaut_Mooring_Update
…n TurbineAssemblyLine
…RBIT into SemiTaut_Mooring_Update
* Added check for mixed phase start types. * Added ProjectManager.start date and conditional logic to calculate phase dates if weather is not defined or phase starts are defined as ints. * Revised logic for calculating defined start time. * Added fixed timedelta functionality to dependent phases. * Added tests for fixed amount dependent phases. * Added test for phase_dates. * Removed ceil from several methods in ProjectManager.
RHammond2
added
enhancement
RHammond2
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Awesome work getting this all integrated, @nRiccobo! This was a lot more than you made it out to be, so kudos to getting this all wrapped up. There are a lot of comments, but they're all straightforward fixes and mostly deal with cleaning up the code. Otherwise, this is great!
… Aligned install with moored install
RHammond2
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I altered some of the logic that was proposed in ORBIT/SemiTaut_Mooring_Update. My goal was to merge these features into the existing workflow of ORBIT, rather than having several a near identical files/classes that effectively calculate the same results.
I added more user inputs to specify
mooring_typeandanchor_typewhich should switch the model to use one calcution method over another. Everything should default to "Catenary" mooring type and "Suction Pile" anchor types. The new features were for "SemiTaut" and "Drag Embedment". The trajectory of the mooring system installation has been to replace generic calls like, "support vessel" with the more updated represented, ahts vessel. So, I added some deprecated warnings if the user still calls the older vessels. I also adjusted which "expected configs" were optional so as to avoid any KeyErrors or MissingInputs.I fixed the interp1d issue such that if the water depth was outside the bounds of the interpolation object for the "SemiTaut", it would not give an error. I chose to extrapolates linearly from the value boundaries.
For the time being, I left the SemiTautMooringSystem() class and FloatingOffshoreSubstation() to verify that the features I incorporated into MooringSystem() and OffshoreSubstation() will yield the same results. They do. I also added some tests to prove so. When we're ready to merge dev->main, I will clean these duplicated classes up. Lastly, I updated example 5. Example Floating Project.ipynb.